mirror of
https://github.com/lynchaos/ashvale-station.git
synced 2026-09-12 20:52:23 +00:00
kemalandClaude Opus 5
154071a791
The board carries two independent thermometers and the code averaged them into temp_raw without ever recording either. Measured over 12 samples on a real station: HTS221 30.973 C at sd 0.060, LPS25HB 29.810 C at sd 0.443, a standing gradient of 1.163 C with the SoC at 44.55 C. Two things follow from that and neither is possible without the raw channels. A plain average of a quiet sensor and one seven times noisier lands at sd 0.223 where inverse-variance weighting reaches 0.060, and the gradient between two chips at different distances from the SoC is a second observation of self-heating that could identify the compensator's k with no reference thermometer. Both need history, and history cannot be backfilled, so the columns land on their own ahead of the work that consumes them. CREATE TABLE IF NOT EXISTS is a no-op against a table that already exists, so adding to COLUMNS would have reached a fresh install and silently missed every station already running, then surfaced as an OperationalError inside insert_telemetry. That sits on the sample loop, so it takes a station down rather than leaving a gap. Store now reconciles the table against COLUMNS on open, which makes every future column addition safe rather than just this one. The simulator gains the same two channels, with couplings solved so their forward models average to exactly the k = 0.55 the compensator is tuned against. Aggregate behaviour is unchanged; only the per-channel detail is new. Simulated temp_raw noise does rise from 0.05 to 0.223, which is not a regression but the end of an over-optimistic figure: it was modelling the quiet sensor and calling it the average. Co-Authored-By: Claude Opus 5 <[email protected]>
94 lines
3.6 KiB
Python
94 lines
3.6 KiB
Python
# Copyright 2026 Kemal Yaylali
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""Schema migration.
|
|
|
|
The column-addition test is the important one. CREATE TABLE IF NOT EXISTS is a
|
|
no-op against a table that already exists, so every new entry in COLUMNS
|
|
reaches a fresh install and silently misses every station already running. It
|
|
then surfaces as an OperationalError inside insert_telemetry, which sits on the
|
|
sample loop, so a column addition takes a live station down rather than merely
|
|
leaving a gap in its record.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sqlite3
|
|
import time
|
|
|
|
import pytest
|
|
|
|
from ashvale.storage import COLUMNS, Store
|
|
|
|
|
|
def _cols(path: str) -> set[str]:
|
|
with sqlite3.connect(path) as c:
|
|
return {r[1] for r in c.execute("PRAGMA table_info(telemetry)")}
|
|
|
|
|
|
def test_fresh_database_has_every_declared_column(tmp_path):
|
|
p = str(tmp_path / "fresh.db")
|
|
Store(p)
|
|
assert not [c for c in COLUMNS if c not in _cols(p)]
|
|
|
|
|
|
def test_migration_adds_a_new_column_without_touching_the_rows(tmp_path):
|
|
"""Simulates a station that has been running since before a column existed."""
|
|
p = str(tmp_path / "old.db")
|
|
legacy = [c for c in COLUMNS if c not in ("temp_h", "temp_p")]
|
|
with sqlite3.connect(p) as c:
|
|
c.execute(f"CREATE TABLE telemetry (ts REAL PRIMARY KEY, "
|
|
f"{', '.join(f'{x} REAL' for x in legacy if x != 'ts')}, "
|
|
f"tier INTEGER NOT NULL DEFAULT 0)")
|
|
c.executemany("INSERT INTO telemetry (ts, temp_raw) VALUES (?, ?)",
|
|
[(float(i), 20.0 + i) for i in range(50)])
|
|
|
|
assert "temp_h" not in _cols(p)
|
|
store = Store(p)
|
|
assert "temp_h" in _cols(p) and "temp_p" in _cols(p)
|
|
|
|
with sqlite3.connect(p) as c:
|
|
n = c.execute("SELECT COUNT(*) FROM telemetry").fetchone()[0]
|
|
old = c.execute("SELECT temp_raw FROM telemetry WHERE ts = 7.0").fetchone()[0]
|
|
assert n == 50, "migration must not lose rows"
|
|
assert old == 27.0, "migration must not disturb existing values"
|
|
|
|
# The point of the exercise: a write using the new columns must now work.
|
|
store.insert_telemetry({"ts": 999.0, "temp_raw": 20.0, "temp_h": 20.6, "temp_p": 19.4})
|
|
with sqlite3.connect(p) as c:
|
|
row = c.execute("SELECT temp_h, temp_p FROM telemetry WHERE ts = 999.0").fetchone()
|
|
assert row == (20.6, 19.4)
|
|
|
|
|
|
def test_migration_is_idempotent(tmp_path):
|
|
p = str(tmp_path / "twice.db")
|
|
Store(p)
|
|
Store(p)
|
|
Store(p)
|
|
assert not [c for c in COLUMNS if c not in _cols(p)]
|
|
|
|
|
|
def test_both_thermometers_survive_a_round_trip(tmp_path):
|
|
"""temp_h and temp_p are logged so the self-heating gradient can be
|
|
recovered later. They cannot be backfilled, so a silent drop is permanent."""
|
|
p = str(tmp_path / "rt.db")
|
|
store = Store(p)
|
|
now = time.time()
|
|
store.insert_telemetry({"ts": now, "temp_raw": 30.39, "temp_h": 30.973,
|
|
"temp_p": 29.810, "cpu_temp": 44.55})
|
|
got = store.window(24.0, ["ts", "temp_h", "temp_p", "cpu_temp"])
|
|
assert got["temp_h"][0] == 30.973
|
|
assert got["temp_p"][0] == 29.810
|
|
assert got["temp_h"][0] - got["temp_p"][0] == pytest.approx(1.163)
|